Timer Logic

Code:

once (GetLightingState("Dining Room Lts") = ON)
then timerstart(3);
begin
once timertime(3) > 2
then SetLightingState("Dining Room Lts", OFF);
begin timerstop(3);
end;
end

I think you've got a few more semicolons than you need.

The semicolon terminates the once statement so what you effectively have is

Code:

once (GetLightingState("Dining Room Lts") = ON)
then timerstart(3);

Which starts the timer when the group goes on.

Followed by

Code:

once timertime(3) > 2
then SetLightingState("Dining Room Lts", OFF);

Which turns the group off when the timer exceeds 2 seconds.

Followed by

Code:

timerstop(3);

Which stops the timer, always.

As a C programmer I find the optional semicolon and optional begin/end in pascal confusing so I like to always put in begins and ends and indent to make the code clearer (in my mind anyway).

It's not entirely clear what you are intending to happen (putting comments as to what you are intending to do also help (even for yourself when you come back 5 years later and wonder what the hell you were thinking)), but if you're trying to also stop the timer at the same time as you are turning off the group then you need to put begin and end around the statements after then "then".

Code:

{Start the timer when the group turn on}
once (GetLightingState("Dining Room Lts") = ON) then 
  begin
    timerstart(3)
  end;

{Stop the timer and turn off the group when the timer has run for > 2 seconds}
once (timertime(3) > 2) then 
  begin
    SetLightingState("Dining Room Lts", OFF);
    timerstop(3);
  end;

Nick

 

To do that it's probably easier to use the "PulseCBusLevel" function..

Here's a copy and paste of something similar from my own touchscreen project.. (note the fan is on a dimmer in my case).

Code:

{ Turns fan on low when light is turned on, then sets it to 
   high for 3 minutes once light is turned off }

once (GetLightingState("Toilet") = ON) then
begin
  SetLightingLevel("Toilet Fan", 70%, "0s");
end;

once (GetLightingState("Toilet") = OFF) then
begin
  PulseCBusLevel("WIRED", "Lighting", "Toilet Fan", 100%, "0s", "0:03:00", 0%);
end;


{If fan is on when light is turned off, let it run for a few minutes}

once (GetLightingState("Ensuite") = OFF) then
begin
  if (GetLightingState("Ensuite Fan") = ON) then
    begin
      PulseCBusLevel("WIRED", "Lighting", "Ensuite Fan", 100%, "0s", "0:03:00", 0%);
    end;
end;