Logic Help

Hi All,

Am looking for a bit of guidance with some logic. I have bathroom lights that are triggered with a PIR but would like the on times to be different depending on the time.

For example between 7am - 11pm want the lights to be on for 2 minutes, then between 11pm - 7am want the lights to be on for 30 seconds.

I have written this in a PAC. Would this work fine? or is there any other or more efficient ways of doing so.

Code:

once (GetCBusState("Manor Farm House", "PICED Triggers", "TRIGGER - MSTR BATHROOM - NICHE") = ON)
      then
begin
  SetLightingLevel("MASTER BED - LED STRIP / GLO19", 100%, "0s");
end;

once (GetCBusState("Manor Farm House", "PICED Triggers", "TRIGGER - MSTR BATHROOM - NICHE") = OFF)
      then
begin
if (Time >= "07:00:00") and
   (Time <= "22:59:59") then
begin
  Delay("0:02:00");  { CHANGE TIME HERE }
  SetLightingLevel("MASTER BED - LED STRIP / GLO19", 0%, "0s");
end;

if (Time >= "23:00:00") and
   (Time <= "06:59:59") then
begin
  Delay("0:00:30"); { CHANGE TIME HERE }
  SetLightingLevel("MASTER BED - LED STRIP / GLO19", 0%, "0s");
end;
 
end;

Thanks for you help

 

There are a couple of issues here when you turn the light off.
Using a delay stops the module running for that length of time. This means any sensor triggers during that time will be missed, so it won't retrigger if you have continuous movement. At the end of the delay, the lights will turn off, then if there is movement, turn on again immediately. This results in the lights flashing off then on again which is not ideal.
Also, the line (Time >= "23:00:00") and (Time <= "06:59:59") can never be true since it can't be after 11pm and before 7am on the same day.

A better way to do this is using the Cbus pulse command which does all the work for you:

Code:

once (GetCBusState("Manor Farm House", "PICED Triggers", "TRIGGER - MSTR BATHROOM - NICHE") = ON) then
    SetLightingLevel("MASTER BED - LED STRIP / GLO19", 100%, "0s");

once (GetCBusState("Manor Farm House", "PICED Triggers", "TRIGGER - MSTR BATHROOM - NICHE") = OFF) then
   if (Time >= "07:00:00") and (Time <= "22:59:59") then
      PulseCBusLevel("Local", "Lighting", "MASTER BED - LED STRIP / GLO19", 100%, "0s", "0:02:00", 0%)
   else
      PulseCBusLevel("Local", "Lighting", "MASTER BED - LED STRIP / GLO19", 100%, "0s", "0:0:30", 0%);

You don't need begin/end around single statements, but it doesn't matter if you put them there.
The ELSE statement is executed if the IF statement isn't so you only need a single test.
I'm assuming the lights are on the local/lighting application. Change it as required.

 

Thanks soo much, had been a while since writing some logic. Was going around in circles.

Thanks for your help again